fix: recursively resolve custom properties in no-invalid-properties #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
added
the
accepted
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the no-invalid-properties ESLint rule where CSS custom properties containing chained var() references were not being fully resolved before validation, causing lexer errors. The fix implements recursive resolution of custom properties to ensure all variables are resolved to their final values before being passed to the CSS lexer.
Key changes:
- Added recursive resolution logic for chained CSS custom properties
- Refactored variable resolution to handle fallback chains and cycles
- Added comprehensive test coverage for various chaining scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/rules/no-invalid-properties.js |
Implemented recursive variable resolution with new helper functions and refactored the main validation logic |
tests/rules/no-invalid-properties.test.js |
Added extensive test cases covering valid and invalid chained variable scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nzakas
requested changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR prevents the lexer from receiving unresolved
var()expressions by recursively resolving chained CSS custom properties. Previously the rule only performed a single-level replacement (e.g.--a: var(--b) → var(--b)), so chained variables like--a: var(--b); --b: 80px;could still leave var() in the value passed to the lexer, causingError: Matching for a tree with var() is not supported.What changes did you make? (Give an overview)
Related Issues
Fixes #200
Is there anything you'd like reviewers to focus on?